Changes between Version 47 and Version 48 of CurationToolMultiGenePhenotypes

Timestamp:

Mar 18, 2015, 12:01:59 PM (6 years ago)

Author:

mah79

Comment:

--

CurationToolMultiGenePhenotypes

@@ -72 +72 @@
   * Maybe a bit more border, too, although there's a risk that would look naff. - KMR: I haven't tried a border yet
   * ~~It'll also help to mention conditions in the header ("Choose evidence and conditions for annotating ...").~~ - DONE KMR 2014-11-10
- * It would be nice to have a way to edit a genotype, in case we make a mistake entering details. - MAH 2014-10-28: agreed; see ideas from today's call below
-  * Ooh, and maybe also a duplicate-and-edit option analogous to "duplicate annotation"? If I have two genotypes, each with six alleles of which five are the same .. (was Antonia asking for something like this on the last call?)
-  * Another thing that might be handy is a list of all the genotypes and their descriptions. It might be too much to put in the genotype box on the paper summary page (some genotypes will be complicated), so maybe a new page or popup, with a "see genotype descriptions" link.
- * Question for curators: should we have a way to delete an unused genotype from a session? We don't want to delete a genotype from the database, but maybe one that gets added in a session but not used could safely be deleted to declutter the interface. - MAH 2014-10-28: see ideas from today's call; see below
+ * ~~It would be nice to have a way to edit a genotype, in case we make a mistake entering details. - MAH 2014-10-28: agreed; see ideas from today's call below~~ moved to updated list below, and thence to SF ticket (mah 2015-03-18)
+  * ~~Ooh, and maybe also a duplicate-and-edit option analogous to "duplicate annotation"? If I have two genotypes, each with six alleles of which five are the same .. (was Antonia asking for something like this on the last call?)~~ moved to updated list below, and thence to SF ticket https://sourceforge.net/p/pombase/curation-tool/778/ (mah 2015-03-18)
+  * ~~Another thing that might be handy is a list of all the genotypes and their descriptions. It might be too much to put in the genotype box on the paper summary page (some genotypes will be complicated), so maybe a new page or popup, with a "see genotype descriptions" link.~~ moved to updated list below, and done (mah 2015-03-18)
+ * ~~Question for curators: should we have a way to delete an unused genotype from a session? We don't want to delete a genotype from the database, but maybe one that gets added in a session but not used could safely be deleted to declutter the interface. - MAH 2014-10-28: see ideas from today's call; see below~~ moved to updated list below, and thence to SF ticket https://sourceforge.net/p/pombase/curation-tool/778/ (mah 2015-03-18)
 
 === Suggested changes from Val ===
@@ -95 +95 @@
    * ~~Not sure how else to describe it -- click to select a term, and nothing happens; click again and it's selected. (This feels like the sort of bug that's going to be a nightmare to reproduce and track down, but I get it in both Firefox and Safari. Happy to demo if that'd help.) Term selection in popups ("Add", "Edit", etc) works as expected. (mah 2014-10-24)~~
    * ~~KMR: thanks, it was easy to reproduce but hard to fix.  :-)  The double click thing is fixed but now sometimes the term detail page doesn't have any detail.  Which isn't ideal.  I'm trying to fix that now.  (2014-11-10)~~ FIXED KMR 2015-03-12
- * Is the annotation extension box supposed to appear in the "duplicate" and "edit" popups when one is not logged in? It does at the moment ... (mah 2014-10-24)  - KMR 2014-11-10: that's definitely a bug
+ * ~~Is the annotation extension box supposed to appear in the "duplicate" and "edit" popups when one is not logged in? It does at the moment ... (mah 2014-10-24)  - KMR 2014-11-10: that's definitely a bug~~ moved to ticket https://sourceforge.net/p/pombase/curation-tool/776/
  * ~~I gave my genotypes names, but the "Add" phenotype popup doesn't use them in the genotype pulldown; I get what I presume is the internal ID gibberish instead, and have to guess which is which. (mah 2014-10-24)~~ - FIXED KMR 2014-11-11
- * It quite happily let me add a duplicate genotype. I think we want to disallow that -- cough up a message such as "That genotype already exists [with the name $genotype_name]", don't we? (mah 2014-10-24)
+ * ~~It quite happily let me add a duplicate genotype. I think we want to disallow that -- cough up a message such as "That genotype already exists [with the name $genotype_name]", don't we? (mah 2014-10-24)~~ moved to ticket https://sourceforge.net/p/pombase/curation-tool/777/
  * ~~Is the definition getting lost for a term suggestion? I can see the name but not the def for suggestions I put in. (mah 2014-10-24)~~ - FIXED KMR 2014-11-10
 
@@ -104 +104 @@
   * we'll also think about what other links might be useful, and where hyperlinks or buttons should go
 
- * Create a separate page for genotype details:
+ * ~~Create a separate page for genotype details:~~ everything on list not marked "DONE" moved to SF ticket https://sourceforge.net/p/pombase/curation-tool/778/ (mah 2015-03-18)
   * ~~Name & description for each genotype used for the paper~~ DONE KMR 2014-11-12
   * "Find a genotype" link - KMR 2014-11-20, this is partly done: there's a find a genotype function but it only searches genotypes from this session.
   * ~~"Add a genotype" link~~ DONE KMR 2014-11-12
-  * For any genotypes, add a "duplicate" link that behaves like the duplicate-annotation link (to speed up & simplify adding new ones)
-  * For genotypes added in this session, add an "edit" link (spout a warning if you try to edit a genotype that has phenotypes annotated to it)
-  * For genotypes added in this session, and NOT used for any annotations, add a "delete this genotype" option
+  * ~~For any genotypes, add a "duplicate" link that behaves like the duplicate-annotation link (to speed up & simplify adding new ones)~~
+  * ~~For genotypes added in this session, add an "edit" link (spout a warning if you try to edit a genotype that has phenotypes annotated to it)~~
+  * ~~For genotypes added in this session, and NOT used for any annotations, add a "delete this genotype" option~~
   * KMR 2014-11-10 - there is now a "Genotypes management" page but the formatting is very basic and the bullet points above aren't done